On 2012/05/08 00:00:09, piscisaureus wrote:
https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc
File src/objects.cc (right):


https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc#newcode6869
src/objects.cc:6869: sink[boundary - from] =
static_cast<sinkchar>(second->Get(0));
MSVC refuses to inline the Get(0) call. My benchmarks show that the difference
is significant though. Any chance we could get a __forceinline or
__attribute__((always_inline)) decorator on the Get method?


https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc#newcode6871
src/objects.cc:6871: CopyChars(sink + boundary - from,
Ditto.

Thanks for the comment. Follow-up CL: http://codereview.chromium.org/10332054/

https://chromiumcodereview.appspot.com/9536011/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to