On 2012/05/11 09:22:56, Jakob wrote:
You did pick the right reviewers, I just didn't get around to commenting
earlier.
I don't think we should set V8_HOST_ARCH_IA32 from the gyp file. The -m32
flag
should be enough to let the preprocessor magic in globals.h figure that
out
automatically.
As for passing -m32, I'd like to fix that in a more generic way. I'll
prepare
a
CL for that shortly. I think the following logic should work:
When v8_target_arch is any of {'ia32', 'arm', 'mips'}, then for host and
target
compiler individually figure out if they support -m32, and if yes, set it;
where
the host compiler is determined by the lookup chain $CXX.host -> $CXX ->
$(which
g++), and the target compiler by $CXX.target -> $CXX -> $(which g++).
One question about this, even the target arch is 64 bit, if it supports
-m32,
always set this option?
http://codereview.chromium.org/10310058/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
