On 2012/05/14 09:19:49, yongsheng.zhu wrote:
Another issue needs you confirmation before I upload the patch:
I'm using $CXX_target and $CXX_host instead of $CXX.target and
$CXX.host(seems
these 2 are invalid names) in the lookup chain. I find 'CXX_target' is
defined
in build/android/envsetup.sh but I'm not sure whether they are suitable.
Uhm... interesting. The Makefiles generated by GYP use "CXX.target", but
you're
right, bash says "export CXX.target=foo" is invalid. Oh well. Let's just use
CXX_target then. (Probably a bug in GYP's make generator, but can easily be
worked around by setting CXX instead.)
Below is the code to check the option for '-m32':
'm32flag': '<!((echo | $(echo ${CXX_host:-${CXX:-$(which g++)}}) -m32 -E
- >
/dev/null 2>&1) && echo -n "-m32" || true)'
'm32flag': '<!((echo | $(echo ${CXX_target:-${CXX:-$(which g++)}}) -m32
-E - >
/dev/null 2>&1) && echo -n "-m32" || true)'
Looks good. Looking forward to your patch :-)
http://codereview.chromium.org/10310058/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
