LGTM with comments addressed.
http://codereview.chromium.org/10387116/diff/2001/src/x64/debug-x64.cc File src/x64/debug-x64.cc (right): http://codereview.chromium.org/10387116/diff/2001/src/x64/debug-x64.cc#newcode117 src/x64/debug-x64.cc:117: __ Integer32ToSmi(kScratchRegister, kScratchRegister); You can convert those values to smi using Smi* value = Smi::FromInt(123); and then use MacroAssembler::Push(Smi*) to push them onto the stack. This way you avoid smi conversions at runtime. http://codereview.chromium.org/10387116/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
