http://codereview.chromium.org/10387116/diff/2001/src/x64/debug-x64.cc
File src/x64/debug-x64.cc (right):
http://codereview.chromium.org/10387116/diff/2001/src/x64/debug-x64.cc#newcode117
src/x64/debug-x64.cc:117: __ Integer32ToSmi(kScratchRegister,
kScratchRegister);
On 2012/05/16 09:59:01, Yang wrote:
You can convert those values to smi using
Smi* value = Smi::FromInt(123);
and then use MacroAssembler::Push(Smi*) to push them onto the stack.
This way
you avoid smi conversions at runtime.
And this is 2-6 times shorter in terms of generated code size!
Done
http://codereview.chromium.org/10387116/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
