I like the change. Some formatting drive-by comments:
https://chromiumcodereview.appspot.com/10412030/diff/4001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10412030/diff/4001/src/mark-compact.cc#newcode1898 src/mark-compact.cc:1898: mark_compact_collector()->RecordSlot(descriptor_start, value_slot, *value_slot); Long line. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h#newcode1938 src/objects-inl.h:1938: Object** DescriptorArray::GetValueSlot(int descriptor_number) { Two empty lines between function definitions. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h#newcode1945 src/objects-inl.h:1945: Object* DescriptorArray::GetValue(int descriptor_number) { Two empty lines between function definitions. Here and in the other places. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newcode4919 src/objects.cc:4919: static_cast<AccessorPair*>(descriptor_array_->GetValue(index / 2)); Long line. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newcode5054 src/objects.cc:5054: Object* object = *HeapObject::RawField(this, kInstanceDescriptorsOrBitField3Offset); Long line. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newcode5082 src/objects.cc:5082: IntrusiveMapTransitionIterator descriptor_iterator(MutatedInstanceDescriptors()); Long line. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h#newcode2504 src/objects.h:2504: // stack-allocated right after creating a descriptor array. By allocating a witness, Long line. https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h#newcode2612 src/objects.h:2612: static const int kDescriptorSize = 3; Maybe sort the constants for the layout by increasing numbers. https://chromiumcodereview.appspot.com/10412030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
