http://codereview.chromium.org/10384196/diff/18003/src/messages.js File src/messages.js (right):
http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode834 src/messages.js:834: return %FunctionGetInferredName(this.fun); On 2012/05/24 02:15:18, Christian Plesner Hansen wrote:
I wonder if the eval case should have been reached if
FunctionGetInferredName
returned null? If so it might make sense to change the logic to that
and keep
the code that's removed here.
Done. http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode956 src/messages.js:956: if (typeNamePrefix[0] != '[' && On 2012/05/24 02:15:18, Christian Plesner Hansen wrote:
Something to consider to make this case easier to detect could be to
change
getTypeName to take an optional argument that, if truthy, tells
getTypeName to
return null in the cases where it otherwise just converts the object
to a
string? Just a thought, it may not be a good idea.
Done. http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode961 src/messages.js:961: if (methodName && functionName.indexOf("." + methodName) != On 2012/05/24 02:15:18, Christian Plesner Hansen wrote:
Is this equivalent to (methodName != this.getFunction().name)? If so
that might
be a simpler way to express it.
Not equivalent; kept this, but fixed indexof -> lastIndexOf. http://codereview.chromium.org/10384196/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
