(Replying using the account I used to use for v8 stuff)
http://codereview.chromium.org/10384196/diff/18003/src/messages.js File src/messages.js (right): http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode834 src/messages.js:834: return %FunctionGetInferredName(this.fun); I wonder if the eval case should have been reached if FunctionGetInferredName returned null? If so it might make sense to change the logic to that and keep the code that's removed here. http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode949 src/messages.js:949: var addSuffix = true; I always get suffix and prefix mixed up. I do the same with left and right. Thanks for fixing it. http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode956 src/messages.js:956: if (typeNamePrefix[0] != '[' && Something to consider to make this case easier to detect could be to change getTypeName to take an optional argument that, if truthy, tells getTypeName to return null in the cases where it otherwise just converts the object to a string? Just a thought, it may not be a good idea. http://codereview.chromium.org/10384196/diff/18003/src/messages.js#newcode961 src/messages.js:961: if (methodName && functionName.indexOf("." + methodName) != Is this equivalent to (methodName != this.getFunction().name)? If so that might be a simpler way to express it. http://codereview.chromium.org/10384196/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
