LGTM, I'll fix the two nits and commit it. Massi
https://chromiumcodereview.appspot.com/10442003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://chromiumcodereview.appspot.com/10442003/diff/1/src/mips/lithium-codegen-mips.cc#newcode2603 src/mips/lithium-codegen-mips.cc:2603: (constant_key << shift_size) + additional_offset); Nit: the line exceeds 80 chars. https://chromiumcodereview.appspot.com/10442003/diff/1/src/mips/lithium-codegen-mips.cc#newcode3644 src/mips/lithium-codegen-mips.cc:3644: __ Addu(scratch0(), key, instr->additional_index()); You moved the declaration "Register scratch = scratch0();" just before this block but you still use "scratch0()" in the Addu: wouldn't it be cleaner using "scratch"? https://chromiumcodereview.appspot.com/10442003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
