Thanks for fixing these.
https://chromiumcodereview.appspot.com/10442003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://chromiumcodereview.appspot.com/10442003/diff/1/src/mips/lithium-codegen-mips.cc#newcode3644 src/mips/lithium-codegen-mips.cc:3644: __ Addu(scratch0(), key, instr->additional_index()); On 2012/05/24 09:01:31, Massi wrote:
You moved the declaration "Register scratch = scratch0();" just before
this
block but you still use "scratch0()" in the Addu: wouldn't it be
cleaner using
"scratch"?
Yes, it is much cleaner. https://chromiumcodereview.appspot.com/10442003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
