https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects-inl.h File src/objects-inl.h (right):
https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects-inl.h#newcode1947 src/objects-inl.h:1947: On 2012/05/24 14:02:25, Michael Starzinger wrote:
Two empty lines between top-level methods.
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects-inl.h#newcode1955 src/objects-inl.h:1955: Object* details = RawGetContentArray()->get(ToDetailsIndex(descriptor_number)); On 2012/05/24 14:02:25, Michael Starzinger wrote:
More than 80 characters.
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.cc#newcode4901 src/objects.cc:4901: // Attention, tricky index manipulation ahead: Two two consecutive indices On 2012/05/24 14:02:25, Michael Starzinger wrote:
Only one "two".
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.cc#newcode4907 src/objects.cc:4907: while ((index / 2) < descriptor_array_->number_of_descriptors()) { On 2012/05/24 14:02:25, Michael Starzinger wrote:
Can we hoist the division by two into a local variable? That would
improve
readability. Like this:
int index = Smi::cast(*DescriptorArrayHeader())->value(); int descriptor_number = raw_index / 2;
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.cc#newcode4919 src/objects.cc:4919: static_cast<AccessorPair*>(descriptor_array_->RawGetValue(index / 2)); On 2012/05/24 14:02:25, Michael Starzinger wrote:
More than 80 characters.
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.cc#newcode5082 src/objects.cc:5082: IntrusiveMapTransitionIterator descriptor_iterator(MutatedInstanceDescriptors()); As discussed offline, leaving it as it is. On 2012/05/24 14:02:25, Michael Starzinger wrote:
Could we just pass the map itself to the constructor of the child
iterator and
do the raw access of the instance descriptor field in there?
More than 80 characters.
https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.h#newcode2479 src/objects.h:2479: inline Object* RawGetValue(int descriptor_number); On 2012/05/24 14:02:25, Michael Starzinger wrote:
These methods are only needed by the IntrusiveMapTransitionIterator,
can we move
them into that class (into the private section)? That prevents others
from
accidentally using these methods.
Also I would rename them to GetRawValue and GetEawDetails which is
more natural
sounding.
Done. https://chromiumcodereview.appspot.com/10411067/diff/1/src/objects.h#newcode2657 src/objects.h:2657: inline FixedArray* RawGetContentArray(); On 2012/05/24 14:02:25, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/10411067/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
