Comments addressed, please take another look.
https://chromiumcodereview.appspot.com/10411067/diff/7001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10411067/diff/7001/src/objects.cc#newcode4922 src/objects.cc:4922: ((raw_index & 1) == 0) ? accessors->getter():accessors->setter(); On 2012/05/25 12:18:00, Michael Starzinger wrote:
Spaces to the left and right of ":". I know it will break the line,
but we just
don't compress operators to avoid line breaking.
Done. https://chromiumcodereview.appspot.com/10411067/diff/7001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10411067/diff/7001/src/objects.h#newcode2423 src/objects.h:2423: friend class IntrusiveMapTransitionIterator; On 2012/05/25 12:18:00, Michael Starzinger wrote:
Move that to the bottom of the class (or at least into the private
section). Done. https://chromiumcodereview.appspot.com/10411067/diff/7001/src/objects.h#newcode2480 src/objects.h:2480: On 2012/05/25 12:18:00, Michael Starzinger wrote:
Remove this empty line.
Done. https://chromiumcodereview.appspot.com/10411067/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
