PTAL.
https://chromiumcodereview.appspot.com/10388047/diff/1015/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/src/hydrogen.cc#newcode4278 src/hydrogen.cc:4278: CHECK_ALIVE({}); On 2012/05/30 13:08:55, Michael Starzinger wrote:
Can we rewrite that to use the following syntax. I think that's more
in sync
with the rest of the code.
HInstruction* store; CHECK_ALIVE(store = BuildStoreNamed(literal, value, property));
Done. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/hydrogen.cc#newcode4631 src/hydrogen.cc:4631: CHECK_ALIVE({}); On 2012/05/30 13:08:55, Michael Starzinger wrote:
Likewise. Also for the rest of the file.
Done. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode1769 src/objects.cc:1769: result_object = SetPropertyViaPrototypes( On 2012/05/30 13:08:55, Michael Starzinger wrote:
The method call should fit into one line if we break right after the
'=' sign. Done. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode2051 src/objects.cc:2051: void JSObject::LookupCallbackSetterInPrototypes(String* name, On 2012/05/30 13:08:55, Michael Starzinger wrote:
Can we rename this to "LookupRealNamedProperty" or something similar?
At least
the current name makes no sense anymore I think.
A method of that name already exists, but does something slightly different. However, it seems that the difference was rather incidental, so I just removed this lookup function altogether. Achievement unlocked: simplified one instance of property handling. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode2134 src/objects.cc:2134: *done = !!(attr & READ_ONLY); On 2012/05/30 13:08:55, Michael Starzinger wrote:
Why not not not use no negation?
Standard JS idiom for (explicitly) converting to a proper bool. ;) https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode2150 src/objects.cc:2150: ; // Fall through On 2012/05/30 13:08:55, Michael Starzinger wrote:
Fall through to nothing makes no sense, can we just use "break;" here?
Done. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode2944 src/objects.cc:2944: MaybeObject* result_object = SetPropertyViaPrototypes( On 2012/05/30 13:08:55, Michael Starzinger wrote:
The method call should fit into one line if we break right after the
'=' sign. Done. https://chromiumcodereview.appspot.com/10388047/diff/1015/test/mjsunit/fuzz-accessors.js File test/mjsunit/fuzz-accessors.js (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/test/mjsunit/fuzz-accessors.js#newcode69 test/mjsunit/fuzz-accessors.js:69: print("running"); On 2012/05/30 13:08:55, Michael Starzinger wrote:
I think we should just remove all of this debugging code again.
Done. https://chromiumcodereview.appspot.com/10388047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
