LGTM.
https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/src/objects.cc#newcode2051 src/objects.cc:2051: void JSObject::LookupCallbackSetterInPrototypes(String* name, On 2012/05/31 13:31:28, rossberg wrote:
On 2012/05/30 13:08:55, Michael Starzinger wrote: > Can we rename this to "LookupRealNamedProperty" or something
similar? At least
> the current name makes no sense anymore I think.
A method of that name already exists, but does something slightly
different.
However, it seems that the difference was rather incidental, so I just
removed
this lookup function altogether.
Achievement unlocked: simplified one instance of property handling.
Nice. https://chromiumcodereview.appspot.com/10388047/diff/1015/test/mjsunit/regress/regress-334.js File test/mjsunit/regress/regress-334.js (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/test/mjsunit/regress/regress-334.js#newcode50 test/mjsunit/regress/regress-334.js:50: print(i); On 2012/05/30 13:08:55, Michael Starzinger wrote:
Can we remove this debugging code again.
I think you missed that one. https://chromiumcodereview.appspot.com/10388047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
