http://codereview.chromium.org/10444055/diff/4005/src/factory.cc File src/factory.cc (right):
http://codereview.chromium.org/10444055/diff/4005/src/factory.cc#newcode918 src/factory.cc:918: if (LinearSearchUnsorted(*result, *key, descriptor_count) == Add a enum { EXPECT_SORTED, EXPECT_UNSORTED } and put both implementations in LinearSearch on the descriptor that take the enum selector as another parameter. http://codereview.chromium.org/10444055/diff/4005/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/10444055/diff/4005/src/mark-compact.cc#newcode1867 src/mark-compact.cc:1867: // printf("marking: %p\n", static_cast<void*>(descriptors)); Remove debugging code. http://codereview.chromium.org/10444055/diff/4005/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/10444055/diff/4005/src/objects-inl.h#newcode1874 src/objects-inl.h:1874: // immutable again. Re-enable this assert appropriately. http://codereview.chromium.org/10444055/diff/4005/src/objects-printer.cc File src/objects-printer.cc (right): http://codereview.chromium.org/10444055/diff/4005/src/objects-printer.cc#newcode275 src/objects-printer.cc:275: break; Please add a printer for the transition map in the descriptor array so that it's possible to output this information. http://codereview.chromium.org/10444055/diff/4005/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10444055/diff/4005/src/objects.cc#newcode1571 src/objects.cc:1571: { nit: No need for this whitespace change. http://codereview.chromium.org/10444055/diff/4005/src/objects.cc#newcode2321 src/objects.cc:2321: // Only remember the map transition if the object's map is NOT equal to nit: indentation http://codereview.chromium.org/10444055/diff/4005/src/objects.cc#newcode4039 src/objects.cc:4039: { MaybeObject* maybe = map()->CopyDropTransitions(false); This should be an enum rather than a bool, it's really difficult to see what the parameter means at the usage site. http://codereview.chromium.org/10444055/diff/4005/src/objects.cc#newcode4945 src/objects.cc:4945: if (descriptor_array_->MayContainTransitions()) This is confusing. What does descriptor iteration have to do with transition? Perhaps another predicate name, even if it does the same thing? http://codereview.chromium.org/10444055/diff/4005/src/objects.h File src/objects.h (right): http://codereview.chromium.org/10444055/diff/4005/src/objects.h#newcode2405 src/objects.h:2405: DECL_ACCESSORS(elements_transition, Map) probably should call this elements_transition_map http://codereview.chromium.org/10444055/diff/4005/src/objects.h#newcode2409 src/objects.h:2409: ASSERT(length() >= kFirstIndex || IsEmpty()); ASSERT(length() > kFirstIndex || length() == kTransitionsIndex || IsEmpty()); http://codereview.chromium.org/10444055/diff/4005/src/objects.h#newcode2565 src/objects.h:2565: bool mutable_transitions); Turn this into an enum. http://codereview.chromium.org/10444055/diff/4005/src/objects.h#newcode4792 src/objects.h:4792: MUST_USE_RESULT MaybeObject* CopyDropTransitions(bool mutable_transitions); Enum instead of bool http://codereview.chromium.org/10444055/diff/4005/src/property.cc File src/property.cc (right): http://codereview.chromium.org/10444055/diff/4005/src/property.cc#newcode60 src/property.cc:60: PrintF(out, " -map:\n"); Make sure this debugging information is available somewhere. http://codereview.chromium.org/10444055/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
