LGTM with nits.
http://codereview.chromium.org/10535004/diff/4001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7403 src/objects.cc:7403: if (Marking::MarkBitFrom(map).Get()) { Nit: To be more consistent with the rest of the code, remove the braces and put the return on the same line. http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7422 src/objects.cc:7422: bool keep_entry = false; Move the initialization to the CALLBACKS case, this is more local. http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7438 src/objects.cc:7438: if (ClearBackPointer(heap, array->get(j))) { Just use "target", it's cleaner... ;-) http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7453 src/objects.cc:7453: Object* setter = accessors->setter(); Move this down before "if (setter->IsMap())...", again making everything as local as possible. http://codereview.chromium.org/10535004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
