http://codereview.chromium.org/10535004/diff/4001/src/objects.cc File src/objects.cc (right):
http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7403 src/objects.cc:7403: if (Marking::MarkBitFrom(map).Get()) { On 2012/06/05 10:52:01, Sven Panne wrote:
Nit: To be more consistent with the rest of the code, remove the
braces and put
the return on the same line.
Done. http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7422 src/objects.cc:7422: bool keep_entry = false; On 2012/06/05 10:52:01, Sven Panne wrote:
Move the initialization to the CALLBACKS case, this is more local.
Done. http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7438 src/objects.cc:7438: if (ClearBackPointer(heap, array->get(j))) { On 2012/06/05 10:52:01, Sven Panne wrote:
Just use "target", it's cleaner... ;-)
Done. http://codereview.chromium.org/10535004/diff/4001/src/objects.cc#newcode7453 src/objects.cc:7453: Object* setter = accessors->setter(); On 2012/06/05 10:52:01, Sven Panne wrote:
Move this down before "if (setter->IsMap())...", again making
everything as
local as possible.
Done. http://codereview.chromium.org/10535004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
