More comments.
https://chromiumcodereview.appspot.com/10534006/diff/1/src/scopes.h File src/scopes.h (right): https://chromiumcodereview.appspot.com/10534006/diff/1/src/scopes.h#newcode43 src/scopes.h:43: explicit VariableMap(Zone* zone); This is probably cleaner still if the zone is stored in the object. On 2012/06/05 14:21:39, sanjoy wrote:
On 2012/06/05 13:42:35, danno wrote: > Seems weird that you have to pass this into the constructor and
again in
> Declare. Cache as member?
I figured not adding a member will save some space. :)
Moreover, Declare is called only once in a couple of places, and in
all those
places I already have a Zone.
https://chromiumcodereview.appspot.com/10534006/diff/10001/src/splay-tree-inl.h File src/splay-tree-inl.h (right): https://chromiumcodereview.appspot.com/10534006/diff/10001/src/splay-tree-inl.h#newcode49 src/splay-tree-inl.h:49: } Store the allocator inside the splay tree so that you can use the existing code. https://chromiumcodereview.appspot.com/10534006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
