http://codereview.chromium.org/10534006/diff/3003/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10534006/diff/3003/src/hydrogen.cc#newcode6958
src/hydrogen.cc:6958: AddInstruction(global_object);
This is an unrelated change, can you please remove it from this patch?

http://codereview.chromium.org/10534006/diff/3003/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/10534006/diff/3003/src/parser.cc#newcode1557
src/parser.cc:1557: interface->Add(names[i], inner, ok, zone());
Move zone() to be the third parameter so that the CHECK_OK parameter
still works.

http://codereview.chromium.org/10534006/diff/3003/src/scopes.h
File src/scopes.h (right):

http://codereview.chromium.org/10534006/diff/3003/src/scopes.h#newcode72
src/scopes.h:72: maps_[i] = new VariableMap(zone);
Where does this allocation come from? It looks like it's from the malloc
heap, that doesn't seem right.

http://codereview.chromium.org/10534006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to