LGTM (with one comment and one nit).
https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc File src/stub-cache.cc (right): https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#newcode178 src/stub-cache.cc:178: ASSERT(getter->IsSpecFunction()); Shouldn't that be getter->IsJSFunction() here, or does it correctly handle function proxies? https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#newcode180 src/stub-cache.cc:180: // Note: map holder = receiver, CheckType = RECEIVER_MAP_CHECK; I don't understand this comment. Can we either turn it into a full sentence or drop it? https://chromiumcodereview.appspot.com/10515008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
