Reviewers: Michael Starzinger, Vyacheslav Egorov, Message: Rebasing and landing...
https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc File src/stub-cache.cc (right): https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#newcode178 src/stub-cache.cc:178: ASSERT(getter->IsSpecFunction()); On 2012/06/08 07:58:33, Michael Starzinger wrote:
Shouldn't that be getter->IsJSFunction() here, or does it correctly
handle
function proxies?
This was just a leftover of a previous weaker typing with Object instead of JSFunction, so I'll just remove that line. https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#newcode180 src/stub-cache.cc:180: // Note: map holder = receiver, CheckType = RECEIVER_MAP_CHECK; On 2012/06/08 07:58:33, Michael Starzinger wrote:
I don't understand this comment. Can we either turn it into a full
sentence or
drop it?
And this was just a leftover when trying to make sense of the CallIC stuff used for this LoadIC => will remove that line. Description: Added LoadIC stub for getters. Removed some dead constants on the way. Please review this at https://chromiumcodereview.appspot.com/10515008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/stub-cache-arm.cc M src/ia32/stub-cache-ia32.cc M src/ic.cc M src/mips/stub-cache-mips.cc M src/objects.h M src/stub-cache.h M src/stub-cache.cc M src/x64/stub-cache-x64.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
