https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h File include/v8-profiler.h (right):
https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h#newcode487 include/v8-profiler.h:487: static size_t GetUsedMemorySize(); The name isn't very clear. How about GetMemorySizeUsedByProfiler? https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc#newcode1548 src/profile-generator.cc:1548: size_t size = sizeof(*this); I think we need to mention in declarations of all these classes that after adding a new field one needs to update the corresponding size-calculating functions. https://chromiumcodereview.appspot.com/10535096/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
