https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc#newcode1548 src/profile-generator.cc:1548: size_t size = sizeof(*this); On 2012/06/11 09:59:20, loislo wrote:
On 2012/06/11 09:47:19, Mikhail Naganov (Chromium) wrote: > I think we need to mention in declarations of all these classes that
after
> adding a new field one needs to update the corresponding
size-calculating
> functions.
2 alexeif: please provide a run-time assert or even compile time
assert for the
case when someone added a member and don't declared it in a members
list. It'd
be something like sizeof(this) == MembersSize()
Compile-time assert is preferred. https://chromiumcodereview.appspot.com/10535096/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
