LGTM. I reviewed diffs between patch sets 2/3 and 1. Rubber-stamping patch
set
1.
https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc
File src/runtime.cc (right):
https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc#newcode11718
src/runtime.cc:11718: continue;
Instead of multiple "continue" statements, I think it would be more
readable to make a boolean variable with descriptive name (e.g.
"found_lazily_compilable_candidate") and then do a single check
if (!found...) continue.
https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc#newcode11774
src/runtime.cc:11774: if (target_function.is_null()) {
Maybe add ASSERT(target->allows_lazy_compilation_without_context()) ?
https://chromiumcodereview.appspot.com/10543141/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
