Comments addressed. Landing ...
https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc#newcode11718 src/runtime.cc:11718: continue; On 2012/06/14 08:37:24, ulan wrote:
Instead of multiple "continue" statements, I think it would be more
readable to
make a boolean variable with descriptive name (e.g. "found_lazily_compilable_candidate") and then do a single check
if (!found...) continue.
Done. Named the flag "found_next_candidate", because it also considers functions that are already compiled. https://chromiumcodereview.appspot.com/10543141/diff/8001/src/runtime.cc#newcode11774 src/runtime.cc:11774: if (target_function.is_null()) { On 2012/06/14 08:37:24, ulan wrote:
Maybe add ASSERT(target->allows_lazy_compilation_without_context()) ?
That assert is already in SharedFunctionInfo::CompileLazy. https://chromiumcodereview.appspot.com/10543141/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
