LGTM (if one comment and one nit is addressed).
https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc File src/factory.cc (right): https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc#newcode555 src/factory.cc:555: ? function_info->SearchOptimizedCodeMap(context->global_context()) We need to do this search anyways, even if the function is bound, so let's hoist the search out to do it only once. https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc#newcode583 src/factory.cc:583: function_info->SearchOptimizedCodeMap(context->global_context()); Drop this search and the outer flag check. https://chromiumcodereview.appspot.com/10103035/diff/38005/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10103035/diff/38005/src/objects.cc#newcode7583 src/objects.cc:7583: set_optimized_code_map(Smi::FromInt(0)); It would simplify the runtime code if we would initialize this with the empty fixed array. The FastNewClosureStub however would need to compare against a root pointer instead of doing a Smi(0) check. I am not sure how much slower the pointer comparison will be. https://chromiumcodereview.appspot.com/10103035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
