Thanks for the review. Landing.
https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc File src/factory.cc (right): https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc#newcode555 src/factory.cc:555: ? function_info->SearchOptimizedCodeMap(context->global_context()) On 2012/06/14 13:51:32, Michael Starzinger wrote:
We need to do this search anyways, even if the function is bound, so
let's hoist
the search out to do it only once.
Good point. Done. https://chromiumcodereview.appspot.com/10103035/diff/38005/src/factory.cc#newcode583 src/factory.cc:583: function_info->SearchOptimizedCodeMap(context->global_context()); On 2012/06/14 13:51:32, Michael Starzinger wrote:
Drop this search and the outer flag check.
Done. https://chromiumcodereview.appspot.com/10103035/diff/38005/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10103035/diff/38005/src/objects.cc#newcode7583 src/objects.cc:7583: set_optimized_code_map(Smi::FromInt(0)); On 2012/06/14 13:51:32, Michael Starzinger wrote:
It would simplify the runtime code if we would initialize this with
the empty
fixed array. The FastNewClosureStub however would need to compare
against a root
pointer instead of doing a Smi(0) check. I am not sure how much slower
the
pointer comparison will be.
I'll leave it as is for now. I assume it should not make a big difference in terms of performance, but I'd like to confirm that before changing it. https://chromiumcodereview.appspot.com/10103035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
