http://codereview.chromium.org/10640012/diff/2001/src/api.cc File src/api.cc (right):
http://codereview.chromium.org/10640012/diff/2001/src/api.cc#newcode6376 src/api.cc:6376: template<bool HasCompilationBlock> On 2012/06/22 11:08:36, Erik Corry wrote:
This should be named_like_this, but I wonder whether this
templatization is
worth it. Do you have benchmark runs showing that just testing last_block_before_compilation_ is too slow?
Reverted. http://codereview.chromium.org/10640012/diff/2001/src/api.cc#newcode6453 src/api.cc:6453: // ASSERT this. On 2012/06/22 11:08:36, Erik Corry wrote:
ASSERT -> Assert (in the comment)
Fixed. http://codereview.chromium.org/10640012/diff/2001/src/api.cc#newcode6476 src/api.cc:6476: if (extension->next) { On 2012/06/22 11:08:36, Erik Corry wrote:
We don't allow implicit conversions to bool.
Fixed. http://codereview.chromium.org/10640012/diff/2001/src/api.cc#newcode6479 src/api.cc:6479: if (extension->previous) { On 2012/06/22 11:08:36, Erik Corry wrote:
and here
Fixed. http://codereview.chromium.org/10640012/diff/2001/src/api.h File src/api.h (right): http://codereview.chromium.org/10640012/diff/2001/src/api.h#newcode415 src/api.h:415: hidden_extensions_head_(NULL) { } On 2012/06/22 11:08:36, Erik Corry wrote:
Instead of 'hidden' may I suggest 'persistent'. That is what we have
used other
places where we have non-stack based handles that do not have a scope
based
lifetime.
Done. http://codereview.chromium.org/10640012/diff/2001/src/compiler.h File src/compiler.h (right): http://codereview.chromium.org/10640012/diff/2001/src/compiler.h#newcode178 src/compiler.h:178: void RememberHiddenExtensions( On 2012/06/22 11:08:36, Erik Corry wrote:
Could be called StorePersistentExtensions.
Fixed. http://codereview.chromium.org/10640012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
