Will land after running tests in debug mode.
http://codereview.chromium.org/10640012/diff/27001/src/api.cc File src/api.cc (right): http://codereview.chromium.org/10640012/diff/27001/src/api.cc#newcode6409 src/api.cc:6409: for (DeferredHandles* deferred = deferred_handles_head_; deferred; On 2012/06/27 10:28:15, Erik Corry wrote:
Please put the parts of a for loop either all on one line or on 3
lines, not 2
and 1. Also we don't allow implicit boolean conversions so you have
to compare
with NULL.
Fixed. http://codereview.chromium.org/10640012/diff/27001/src/api.cc#newcode6450 src/api.cc:6450: ASSERT(last_handle_before_deferred_block_); On 2012/06/27 10:28:15, Erik Corry wrote:
No implicit boolean conversions.
Fixed. http://codereview.chromium.org/10640012/diff/27001/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/10640012/diff/27001/src/handles.cc#newcode980 src/handles.cc:980: On 2012/06/27 10:28:15, Erik Corry wrote:
Missing newline.
Fixed. http://codereview.chromium.org/10640012/diff/27001/src/handles.cc#newcode1001 src/handles.cc:1001: CompilationHandleScope::CompilationHandleScope(CompilationInfo* info) On 2012/06/27 10:28:15, Erik Corry wrote:
This should also go somewhere else (perhaps inlined in the class
declaration). Moved to compiler.h http://codereview.chromium.org/10640012/diff/27001/src/handles.h File src/handles.h (right): http://codereview.chromium.org/10640012/diff/27001/src/handles.h#newcode176 src/handles.h:176: // alive till as long as the DeferredHandles object is alive. On 2012/06/27 10:28:15, Erik Corry wrote:
till as long as -> as long as
Fixed. http://codereview.chromium.org/10640012/diff/27001/src/handles.h#newcode194 src/handles.h:194: class CompilationInfo; On 2012/06/27 10:28:15, Erik Corry wrote:
This declaration and the CompilationHandleScope are uses of handles
and not part
of the handles interface, so they should go somewhere else, like
perhaps
hydrogen.h
Moved to compiler.h. http://codereview.chromium.org/10640012/diff/27001/src/handles.h#newcode197 src/handles.h:197: // A wrapper around a CompilationInfo that Detaches the Handles from On 2012/06/27 10:28:15, Erik Corry wrote:
Detaches -> detaches
Fixed. http://codereview.chromium.org/10640012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
