LGTM
In the CL description, change "BUG=..." to "BUG=v8:..." otherwise it
references
a Chromium bug.
http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc#newcode1473
test/cctest/test-heap-profiler.cc:1473: snapshot =
v8::HeapProfiler::TakeSnapshot(v8_str("HiddenPropertiesFastCase2"));
nit: 80 chars
http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc#newcode1477
test/cctest/test-heap-profiler.cc:1477: hidden_props = GetProperty(c,
v8::HeapGraphEdge::kInternal, "hidden_properties");
nit: 80 chars
http://codereview.chromium.org/10692058/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
