http://codereview.chromium.org/10692058/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
http://codereview.chromium.org/10692058/diff/1/src/profile-generator.cc#newcode2189 src/profile-generator.cc:2189: if (k->length() > 0) { On 2012/07/02 12:12:45, Vyacheslav Egorov (Google) wrote:
Consider comparing against Heap::hidden_symbol()
Done. http://codereview.chromium.org/10692058/diff/1/src/profile-generator.cc#newcode2196 src/profile-generator.cc:2196: OS::Print("Empty name for fast property 1\n"); On 2012/07/02 12:12:45, Vyacheslav Egorov (Google) wrote:
remove OS::Print
Done. http://codereview.chromium.org/10692058/diff/1/src/profile-generator.cc#newcode2205 src/profile-generator.cc:2205: if (k->length() > 0) { On 2012/07/02 12:12:45, Vyacheslav Egorov (Google) wrote:
Consider comparing against Heap::hidden_symbol
Done. http://codereview.chromium.org/10692058/diff/1/src/profile-generator.cc#newcode2208 src/profile-generator.cc:2208: OS::Print("Empty name for fast property 2\n"); On 2012/07/02 12:12:45, Vyacheslav Egorov (Google) wrote:
remove OS::Print
Done. http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc#newcode1473 test/cctest/test-heap-profiler.cc:1473: snapshot = v8::HeapProfiler::TakeSnapshot(v8_str("HiddenPropertiesFastCase2")); On 2012/07/02 12:16:19, Mikhail Naganov (Chromium) wrote:
nit: 80 chars
Done. http://codereview.chromium.org/10692058/diff/1/test/cctest/test-heap-profiler.cc#newcode1477 test/cctest/test-heap-profiler.cc:1477: hidden_props = GetProperty(c, v8::HeapGraphEdge::kInternal, "hidden_properties"); On 2012/07/02 12:16:19, Mikhail Naganov (Chromium) wrote:
nit: 80 chars
Done. http://codereview.chromium.org/10692058/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
