Just a few nits/suggestions. Otherwise LGTM.
https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1595 tools/grokdump.py:1595: def do_ascii(self, address): How about naming this command "dascii" or just "da", because it belongs to the "dump" category. https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1597 tools/grokdump.py:1597: Print ASCII string starting at specified address. Indent that by one space for consistency. https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1612 tools/grokdump.py:1612: print "%s" % string Maybe we should put parentheses around the string. I am not sure about that, I'll leave it up to you. https://chromiumcodereview.appspot.com/10697067/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
