https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py File tools/grokdump.py (right):
https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1595 tools/grokdump.py:1595: def do_ascii(self, address): On 2012/07/03 11:43:16, Michael Starzinger wrote:
How about naming this command "dascii" or just "da", because it
belongs to the
"dump" category.
Done. https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1597 tools/grokdump.py:1597: Print ASCII string starting at specified address. On 2012/07/03 11:43:16, Michael Starzinger wrote:
Indent that by one space for consistency.
Done. https://chromiumcodereview.appspot.com/10697067/diff/1/tools/grokdump.py#newcode1612 tools/grokdump.py:1612: print "%s" % string On 2012/07/03 11:43:16, Michael Starzinger wrote:
Maybe we should put parentheses around the string. I am not sure about
that,
I'll leave it up to you.
Quotes don't work that well since the string may not terminate cleanly (I don't try to detect null termination, but assume the string to terminate when the ASCII content ends). https://chromiumcodereview.appspot.com/10697067/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
