LGTM, with comment
http://codereview.chromium.org/10735003/diff/1/test/mjsunit/object-define-property.js File test/mjsunit/object-define-property.js (right): http://codereview.chromium.org/10735003/diff/1/test/mjsunit/object-define-property.js#newcode1144 test/mjsunit/object-define-property.js:1144: testSetterOnProto(446, obj3); Maybe you want some additional tests here where LookupForWrite finds an accessor pair but one without a setter. E.g. you remove an existing setter, but it still has a getter, so that it is readonly. http://codereview.chromium.org/10735003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
