Reviewers: rossberg, Vyacheslav Egorov, Message: Landing...
http://codereview.chromium.org/10735003/diff/1/test/mjsunit/object-define-property.js File test/mjsunit/object-define-property.js (right): http://codereview.chromium.org/10735003/diff/1/test/mjsunit/object-define-property.js#newcode1144 test/mjsunit/object-define-property.js:1144: testSetterOnProto(446, obj3); On 2012/07/04 10:34:09, rossberg wrote:
Maybe you want some additional tests here where LookupForWrite finds
an accessor
pair but one without a setter. E.g. you remove an existing setter, but
it still
has a getter, so that it is readonly.
Done. Description: Handle accessors on the prototype chain in StoreICs. Made stub compiler function signatures a bit more consistent on the way. Please review this at http://codereview.chromium.org/10735003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/stub-cache-arm.cc M src/ia32/stub-cache-ia32.cc M src/ic.cc M src/mips/stub-cache-mips.cc M src/stub-cache.h M src/stub-cache.cc M src/x64/stub-cache-x64.cc M test/mjsunit/accessor-map-sharing.js M test/mjsunit/object-define-property.js -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
