http://codereview.chromium.org/10735003/diff/1/src/ic.cc File src/ic.cc (right):
http://codereview.chromium.org/10735003/diff/1/src/ic.cc#newcode1322 src/ic.cc:1322: if (!FLAG_es5_readonly) return false; On 2012/07/04 11:48:34, Vyacheslav Egorov (Google) wrote:
Sorry, I do not understand why es5_readonly semantics is essential
here.
We already lookup and find setters on the prototype chain and then
invoke them
on writes. What breaks if we start caching that?
Perhaps it isn't necessary, but this patch amends the fixes I made earlier and (had to) put behind that flag -- which, despite the flag's name, also fixed the treatment of inherited setters, except for the oversight here. http://codereview.chromium.org/10735003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
