First round of comments.
https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects-inl.h#newcode3069 src/objects-inl.h:3069: StubMajorKeyField::update(previous, major)); Indentation seems off. Can we also pull this out into a local "updated" variable to be consistent with the other setters? https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects-inl.h#newcode3294 src/objects-inl.h:3294: READ_UINT32_FIELD(this, kKindSpecificFlags1Offset)) + Token::EQ; Can we move the addition of Token::EQ into CompareIC::ComputeOperation(), so that all the magic is in there? https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects-inl.h#newcode3300 src/objects-inl.h:3300: Token::IsCompareOp(static_cast<Token::Value>(value)); There is probably an ASSERT missing around that call. https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects-inl.h#newcode3301 src/objects-inl.h:3301: value -= Token::EQ; Can we move the substraction of Token::EQ into ICCompareStub::FinishCode to have all the magic in there. https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects.h#newcode4531 src/objects.h:4531: static const int kHeaderPaddingStart = kKindSpecificFlags2Offset; Hmm, I am not sure, is that really the right offset? https://chromiumcodereview.appspot.com/10701106/diff/5002/src/objects.h#newcode4538 src/objects.h:4538: // Byte offsets within kKindSpecificFlagsOffset. Adapt the comment to include the number. https://chromiumcodereview.appspot.com/10701106/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
