LGTM (with a few final nits).
https://chromiumcodereview.appspot.com/10701106/diff/9002/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10701106/diff/9002/src/objects.h#newcode4557 src/objects.h:4557: // KindSpecificFlags1 layout (STUB and OPTIMIZED) Can we change "OPTIMIZED" to "OPTIMIZED_FUNCTION" so that it shows up when grepping for it? https://chromiumcodereview.appspot.com/10701106/diff/9002/src/objects.h#newcode4609 src/objects.h:4609: // KindSpecificFlags2 layout (STUB and OPTIMIZED) Likewise. https://chromiumcodereview.appspot.com/10701106/diff/9002/src/objects.h#newcode4625 src/objects.h:4625: // KindSpecificFlags[1] layout (FUNCTION) Can we drop the square brackets? https://chromiumcodereview.appspot.com/10701106/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
