On 2012/07/12 08:38:02, danno wrote:
http://codereview.chromium.org/10700115/diff/3009/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/10700115/diff/3009/src/hydrogen.cc#newcode3087
src/hydrogen.cc:3087: bool HGraph::Optimize(SmartArrayPointer<char>*
deopt_reason) {
Should be "bailout_reason"
http://codereview.chromium.org/10700115/diff/3009/src/lithium.h
File src/lithium.h (right):
http://codereview.chromium.org/10700115/diff/3009/src/lithium.h#newcode676
src/lithium.h:676: static Handle<Code> Codegen(LChunk* chunk);
Why do you need to make this static? If you make it an instance method,
you
don't need the wrapper methods that call through in the subclasses.
This is because LCodeGen works on an LChunk and not an LChunkBase (and
this dependency is not syntactic -- it access fields added by LChunk).
http://codereview.chromium.org/10700115/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
