https://chromiumcodereview.appspot.com/10700115/diff/6/src/compiler.cc File src/compiler.cc (right):
https://chromiumcodereview.appspot.com/10700115/diff/6/src/compiler.cc#newcode51 src/compiler.cc:51: #include "ia32/lithium-ia32.h" On 2012/07/12 11:14:54, danno wrote:
Why do you need these? At this point, all of the calls that you make
to LChunk
and co. shouldn't require the platform specific headers, right?
The register allocator needed an LChunk to operate on. Fixed this by getting to work with an LChunkBase instead. https://chromiumcodereview.appspot.com/10700115/diff/6/src/mips/lithium-mips.h File src/mips/lithium-mips.h (right): https://chromiumcodereview.appspot.com/10700115/diff/6/src/mips/lithium-mips.h#newcode2200 src/mips/lithium-mips.h:2200: return reinterpret_cast<LChunk*>(chunk_base); On 2012/07/12 11:14:54, danno wrote:
I am not sure if this (and others in ia32/x64/ARM) add any value.
Elsewhere in
the runtime, the cast function does additional runtime checks to make
sure the
cast is valid, justifying the existence of the extra function. Here,
no such
check is possible, so I think it's probably better/simpler/less code
just to do
the static_cast directly in the LCodeGen constructor.
Done. https://chromiumcodereview.appspot.com/10700115/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
