Other than addressing comments, changed IsCompilerThread() to return false
if
recompilation is false. This simplifies the assertions and is more
intuitive --
when FLAG_parallel_recompilation is false, we are never on the compiler
thread.
http://codereview.chromium.org/10807024/diff/1102/src/compiler.cc
File src/compiler.cc (right):
http://codereview.chromium.org/10807024/diff/1102/src/compiler.cc#newcode824
src/compiler.cc:824: ASSERT(!closure->IsInRecompileQueue());
On 2012/07/19 16:11:56, Yang wrote:
As discussed, this should probably be a real check (return if already
being
optimized) instead of an assertion.
Done.
http://codereview.chromium.org/10807024/diff/1102/src/compiler.h
File src/compiler.h (right):
http://codereview.chromium.org/10807024/diff/1102/src/compiler.h#newcode382
src/compiler.h:382: bool abort_optimization_;
On 2012/07/19 15:56:01, Yang wrote:
imo checking for BAILED_OUT status after the parallelizable phase is
sufficient
to determine whether to DoPendingAbort. Also please add assertions to
AbortOptimization and DeferAbortOptimization that we are in the
expected thread
(if FLAG_parallel_recompilation).
Done.
http://codereview.chromium.org/10807024/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
