LGTM if comments addressed.
http://codereview.chromium.org/10807024/diff/5007/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/10807024/diff/5007/src/compiler.cc#newcode357 src/compiler.cc:357: return SetLastStatus(BAILED_OUT); Do we handle BAILED_OUT when running this in the parallel thread at all? http://codereview.chromium.org/10807024/diff/5007/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): http://codereview.chromium.org/10807024/diff/5007/src/optimizing-compiler-thread.cc#newcode62 src/optimizing-compiler-thread.cc:62: (void) status; What does this line do? http://codereview.chromium.org/10807024/diff/5007/src/optimizing-compiler-thread.cc#newcode101 src/optimizing-compiler-thread.cc:101: return false; Put this on the previous line or in {}. http://codereview.chromium.org/10807024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
