First round.
BTW, what happened to the GDBJIT support? Is it still broken? Will it be
even
harder to fix now? I can't tell what the impact of this CL is on it.
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/builtins.cc
File src/builtins.cc (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/builtins.cc#newcode1646
src/builtins.cc:1646: JIT_CODE_EVENT(AddCode(functions[i].s_name,
Why do you remove the code event type? It seems that this even if you
don't use this, it will be useful for other systems, like GDB.
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/code-events.cc
File src/code-events.cc (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/code-events.cc#newcode94
src/code-events.cc:94: void CodeEvents::AddCode(Code* code) {
Can you handle this with default parameters with a single AddCode API?
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/code-events.h
File src/code-events.h (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/code-events.h#newcode53
src/code-events.h:53: static void AddCode(Handle<String> name,
I find it a little odd that this interface takes both handles and raw
pointers. You probably should be uniform in the API, using all Handles
or all pointers. Since you call this from pointer-based code, you
probably should keep everything pointer-based, since calling
handle-based APIs from pointer-based code is generally not a good idea.
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/code-events.h#newcode55
src/code-events.h:55: Handle<Code> code,
Order or parameters same? In fact, if both routines are pointer based,
don't you only need a single API call?
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/compiler.cc
File src/compiler.cc (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/compiler.cc#newcode496
src/compiler.cc:496:
JIT_CODE_EVENT(AddCode(Handle<String>(String::cast(script->name())),
I know this is beyond the scope of your change, but is there any way to
unify this with the PROFILE code events, since that seems to be a
bottleneck for all code creation?
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/gdb-jit.cc
File src/gdb-jit.cc (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/gdb-jit.cc#newcode49
src/gdb-jit.cc:49: #elif !defined(WIN32) // DO NOT SUBMIT
What is this change for?
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/mark-compact.cc
File src/mark-compact.cc (right):
http://chromiumcodereview.appspot.com/10795074/diff/1018/src/mark-compact.cc#newcode692
src/mark-compact.cc:692: // DO NOT SUBMIT.
Is this left-over debug code?
http://chromiumcodereview.appspot.com/10795074/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
