https://chromiumcodereview.appspot.com/10795074/diff/16002/src/code-events.cc File src/code-events.cc (right):
https://chromiumcodereview.appspot.com/10795074/diff/16002/src/code-events.cc#newcode66 src/code-events.cc:66: SmartArrayPointer<char> name_cstring = name->ToCString(DISALLOW_NULLS); On 2012/07/30 11:43:36, Mikhail Naganov (Chromium) wrote:
Are you sure this works correctly? SmartArrayPointer is a scoped
pointer, it
will delete its contents automatically. You should call Detach to
unmanage the
pointer. But after that I'm not actually seeing any code that deletes
the
contents of the string.
I think what you need is to add deletion of string contents after
calling the
handler (if it wasn't a static string), and specify this behavior in
the
documentation.
I'm sorry, I haven't realized you are calling the handler inside this code block. So the only point here is to specify in the documentation the lifetime of the string. https://chromiumcodereview.appspot.com/10795074/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
