LGTM (with nits).
https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode1091 src/hydrogen.h:1091: HLoadNamedField* BuildLoadNamedField(HValue* object, I know it's not part of your change, but can we move the declaration of this method into the block of property-related BuildFoo() methods? https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode1095 src/hydrogen.h:1095: HInstruction* BuildLoadNamedGeneric(HValue* object, Likewise. https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode1098 src/hydrogen.h:1098: HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key); Likewise. https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode1154 src/hydrogen.h:1154: bool LookupAccessorPair(Handle<Map> map, Can we have a short comment what this method does and about the semantics of the return value. Also I would move it up a few lines in front of the block of property-related BuildFoo() methods. https://chromiumcodereview.appspot.com/10831047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
