Landing...
http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h File src/hydrogen.h (right): http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1091 src/hydrogen.h:1091: HLoadNamedField* BuildLoadNamedField(HValue* object, On 2012/07/27 09:19:23, Michael Starzinger wrote:
I know it's not part of your change, but can we move the declaration
of this
method into the block of property-related BuildFoo() methods?
Done. http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1095 src/hydrogen.h:1095: HInstruction* BuildLoadNamedGeneric(HValue* object, On 2012/07/27 09:19:23, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1098 src/hydrogen.h:1098: HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key); On 2012/07/27 09:19:23, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1154 src/hydrogen.h:1154: bool LookupAccessorPair(Handle<Map> map, On 2012/07/27 09:19:23, Michael Starzinger wrote:
Can we have a short comment what this method does and about the
semantics of the
return value. Also I would move it up a few lines in front of the
block of
property-related BuildFoo() methods.
Done. http://codereview.chromium.org/10831047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
