http://codereview.chromium.org/10831153/diff/2002/benchmarks/run.js File benchmarks/run.js (right):
http://codereview.chromium.org/10831153/diff/2002/benchmarks/run.js#newcode37 benchmarks/run.js:37: //load('navier-stokes.js'); On 2012/08/06 13:49:24, Toon Verwaest wrote:
Probably shouldn't disable the benchmarks?
Oops! http://codereview.chromium.org/10831153/diff/2002/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/10831153/diff/2002/src/arm/stub-cache-arm.cc#newcode1257 src/arm/stub-cache-arm.cc:1257: Register index = scratch2; On 2012/08/06 13:49:24, Toon Verwaest wrote:
If you do this assignment before passing scratch2 (index) into GeneratePositiveLookup, half of the comment becomes unnecessary.
Done. http://codereview.chromium.org/10831153/diff/2002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10831153/diff/2002/src/objects.cc#newcode3222 src/objects.cc:3222: Map::cast(result)->set_dictionary_map(true); On 2012/08/06 13:49:24, Toon Verwaest wrote:
This is superfluous since CopyNormalized already sets the map to
dictionary_map. Done. http://codereview.chromium.org/10831153/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
