I have some drive-by comments for this CL.
https://chromiumcodereview.appspot.com/10831153/diff/2002/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://chromiumcodereview.appspot.com/10831153/diff/2002/src/ia32/stub-cache-ia32.cc#newcode1110 src/ia32/stub-cache-ia32.cc:1110: receiver, name_reg, scratch1, scratch2, scratch3, callback, name, miss); This performs a dictionary lookup on the receiver, not the holder, we should use "reg" instead of "receiver" in this call. https://chromiumcodereview.appspot.com/10831153/diff/2002/src/ic.cc File src/ic.cc (left): https://chromiumcodereview.appspot.com/10831153/diff/2002/src/ic.cc#oldcode992 src/ic.cc:992: if (!holder->HasFastProperties()) return; What about the KeyedLoadIC? https://chromiumcodereview.appspot.com/10831153/diff/2002/src/ic.cc#oldcode1000 src/ic.cc:1000: if (!holder->HasFastProperties()) return; Why can we generate a JavaScript getter call for a slow holder now? We are not doing any positive dictionary lookup there. https://chromiumcodereview.appspot.com/10831153/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
