Incorporated comments and extended test. Now hunting a bug related to a
no-arg
setter... :-P
https://chromiumcodereview.appspot.com/10836133/diff/8017/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/10836133/diff/8017/src/hydrogen.cc#newcode188
src/hydrogen.cc:188: AddInstruction(new(zone())
HLeaveInlined(state->arguments_pushed()));
On 2012/08/08 15:01:29, Michael Starzinger wrote:
Can we keep the drop_extra and arguments_pushed as local variables at
the top,
IMHO that's cleaner. And maybe also move the target block into a
separate local
variable.
HBasicBlock* block = state->function_return();
Done.
https://chromiumcodereview.appspot.com/10836133/diff/8017/src/hydrogen.cc#newcode6969
src/hydrogen.cc:6969: receiver,
On 2012/08/08 15:01:29, Michael Starzinger wrote:
Can we also rename "receiver" to "implicit_return_value" here for
consistency?
Done.
https://chromiumcodereview.appspot.com/10836133/diff/8017/src/hydrogen.h
File src/hydrogen.h (right):
https://chromiumcodereview.appspot.com/10836133/diff/8017/src/hydrogen.h#newcode745
src/hydrogen.h:745: InliningKind inlining_kind_;
On 2012/08/08 15:01:29, Michael Starzinger wrote:
Can we have a one-liner comment that says this specifies the kind of
call that
was inlined.
Done.
https://chromiumcodereview.appspot.com/10836133/diff/8017/test/mjsunit/compiler/inline-accessors.js
File test/mjsunit/compiler/inline-accessors.js (right):
https://chromiumcodereview.appspot.com/10836133/diff/8017/test/mjsunit/compiler/inline-accessors.js#newcode79
test/mjsunit/compiler/inline-accessors.js:79: function getter1() {
On 2012/08/08 15:01:29, Michael Starzinger wrote:
It might be a good idea to assert that the receiver is passed
correctly in all
of the getters and setters. Something like the following ...
assertSame(obj, this);
Done.
https://chromiumcodereview.appspot.com/10836133/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
