LGTM (with one nit and one important follow-up for the next CL).
https://chromiumcodereview.appspot.com/10836133/diff/9004/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10836133/diff/9004/src/hydrogen.cc#newcode5248 src/hydrogen.cc:5248: Drop(2); It seems dropping the arguments after doing HChceckConstantFunction is the correct order, so it was wrong before. This proves that we don't have test coverage for that and need to add tests. But we can do that in a follow-up CL. https://chromiumcodereview.appspot.com/10836133/diff/9004/src/hydrogen.cc#newcode9299 src/hydrogen.cc:9299: outer = CreateStubEnvironment(outer, target, JS_SETTER, arguments); Can we add a comment specifying which stub is simulated by this artificial environment? https://chromiumcodereview.appspot.com/10836133/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
